Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 as supported version #1545

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add Python 3.13 as supported version #1545

wants to merge 2 commits into from

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (8326a83) to head (3469724).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
+ Coverage   88.45%   88.52%   +0.06%     
==========================================
  Files          78       78              
  Lines       10718    10718              
==========================================
+ Hits         9481     9488       +7     
+ Misses       1237     1230       -7     
Flag Coverage Δ
unittests 88.52% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

eh,

on windows lacks whl for numpy - FTBFS due to too old GCC
  + C:\hostedtoolcache\windows\Python\3.13.0\x64\python.exe C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec\vendored-meson\meson\meson.py setup C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec\.mesonpy-gpxa7lhw -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --native-file=C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec\.mesonpy-gpxa7lhw\meson-python-native-file.ini
172
  The Meson build system
173
  Version: 1.2.99
174
  Source dir: C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec
175
  Build dir: C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec\.mesonpy-gpxa7lhw
176
  Build type: native build
177
  Project name: NumPy
178
  Project version: 1.26.4
179
  C compiler for the host machine: gcc (gcc 8.1.0 "gcc (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0")
180
  C linker for the host machine: gcc ld.bfd 2.30
181
  C++ compiler for the host machine: c++ (gcc 8.1.0 "c++ (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0")
182
  C++ linker for the host machine: c++ ld.bfd 2.30
183
  Cython compiler for the host machine: cython (cython 3.0.11)
184
  Host machine cpu family: x86_64
185
  Host machine cpu: x86_64
186
  
187
  ..\meson.build:28:4: ERROR: Problem encountered: NumPy requires GCC >= 8.4
188
  
189
  A full log can be found at C:\Users\runneradmin\AppData\Local\Temp\pip-install-r0d949oh\numpy_f575f69b4075474e97774f4b45d094ec\.mesonpy-gpxa7lhw\meson-logs\meson-log.txt
190
  [end of output]
191
  
192
  note: This error originates from a subprocess, and is likely not a problem with pip.
193
error: metadata-generation-failed
194

195
Encountered error while generating package metadata.
196

197
See above for output.
198

199
note: This is an issue with the package mentioned above, not pip.
200
hint: See above for details.
201
Error: Process completed with exit code 1.
on linux and OSX - lacks whl for h5py and then FTBFS due to missing libhdf5
copying h5py/tests/data_files/vlen_string_s390x.h5 -> build/lib.linux-x86_64-cpython-313/h5py/tests/data_files
      running build_ext
      Loading library to get build settings and version: libhdf5.so
      error: Unable to load dependency HDF5, make sure HDF5 is installed properly
      Library dirs checked: []
      error: libhdf5.so: cannot open shared object file: No such file or directory
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for h5py
  Building wheel for numpy (pyproject.toml): started
  Building wheel for numpy (pyproject.toml): finished with status 'done'
  Created wheel for numpy: filename=numpy-1.26.4-cp313-cp313-linux_x86_64.whl size=6917287 sha256=a2790cb352590b0d5924b43d008a08bfd0b758e4560e270e20855494541c331c
  Stored in directory: /home/runner/.cache/pip/wheels/8b/2d/9f/b6b46373f328e2ef50388915d351ccacbedac929459b5459bf
  Building wheel for asciitree (pyproject.toml): started
  Building wheel for asciitree (pyproject.toml): finished with status 'done'
  Created wheel for asciitree: filename=asciitree-0.3.3-py3-none-any.whl size=5033 sha256=eb0ddd8ae452df1d50f7395c86a7c11d06492835de1e08088[469](https://github.com/dandi/dandi-cli/actions/runs/12058341039/job/33624847548?pr=1545#step:4:470)a46df3c4de77
  Stored in directory: /home/runner/.cache/pip/wheels/0e/70/f0/bff6301cfa0d49afa79c020bc98c114a9b9c6b3048e62e3200
Successfully built dandi numpy asciitree
Failed to build h5py
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (h5py)

I guess we better wait a little longer

@yarikoptic yarikoptic marked this pull request as draft November 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant